Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [pre-commit.ci] pre-commit autoupdate #2314

Merged
merged 4 commits into from
Sep 5, 2023
Merged

chore: [pre-commit.ci] pre-commit autoupdate #2314

merged 4 commits into from
Sep 5, 2023

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Sep 5, 2023 •
edited by matthewfeickert
Loading

updates:

* Update pre-commit hooks:
   - github.com/astral-sh/ruff-pre-commit: v0.0.281 → v0.0.287
   - github.com/adamchainz/blacken-docs: 1.15.0 → 1.16.0
   - github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1
* Apply requested Ruff changes to src/pyhf/parameters/paramsets.py
  for 'E721 Do not compare types, use `isinstance()`' and
  refactor logic.
* Apply requested mypy changes to src/pyhf/readxml.py to remove
  unused "type: ignore" comment [unused-ignore].

Co-authored-by: Matthew Feickert <matthew.feickert@cern.ch>

@pre-commit-ci
chore: [pre-commit.ci] pre-commit autoupdate
a2b6704 
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.281 → v0.0.287](astral-sh/ruff-pre-commit@v0.0.281...v0.0.287)
- [github.com/adamchainz/blacken-docs: 1.15.0 → 1.16.0](adamchainz/blacken-docs@1.15.0...1.16.0)
- [github.com/pre-commit/mirrors-mypy: v1.4.1 → v1.5.1](pre-commit/mirrors-mypy@v1.4.1...v1.5.1)
@matthewfeickert matthewfeickert self-assigned this Sep 5, 2023
@matthewfeickert matthewfeickert added chore Other changes that don't modify src or test files pre-commit Related to pre-commit hooks need-to-backport tmp label until can be backported to patch release branch labels Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14% ⚠️

Comparison is base (17e80c2) 98.30% compared to head (836fbd9) 98.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2314      +/-   ##
==========================================
- Coverage   98.30%   98.16%   -0.14%     
==========================================
  Files          69       69              
  Lines        4536     4535       -1     
  Branches      802      802              
==========================================
- Hits         4459     4452       -7     
- Misses         45       48       +3     
- Partials       32       35       +3
Flag Coverage Δ
contrib 97.88% <100.00%> (-0.01%) ⬇️
doctest 61.05% <25.00%> (+0.01%) ⬆️
unittests-3.10 ?
unittests-3.11 ?
unittests-3.8 ?
unittests-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/pyhf/parameters/paramsets.py 100.00% <100.00%> (ø)
src/pyhf/readxml.py 96.41% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewfeickert
Copy link
Member

I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit 2325b05 into main Sep 5, 2023
18 of 20 checks passed
@matthewfeickert matthewfeickert deleted the pre-commit-ci-update-config branch September 5, 2023 13:40
@matthewfeickert matthewfeickert mentioned this pull request Sep 6, 2023
Merged
4 tasks
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Sep 6, 2023
matthewfeickert added a commit that referenced this pull request Sep 6, 2023
@matthewfeickert
chore(backport): Update pre-commit hooks (#2317)
db7cad0 
* Backport:
   - PR #2305
   - PR #2314
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewfeickert matthewfeickert matthewfeickert approved these changes

Assignees

@matthewfeickert matthewfeickert

Labels
chore Other changes that don't modify src or test files pre-commit Related to pre-commit hooks
Projects
pyhf v0.8.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@matthewfeickert